vobject icon indicating copy to clipboard operation
vobject copied to clipboard

Check for string-type parameter VALUE

Open martijnvankekem opened this issue 1 year ago • 3 comments

See: https://github.com/sabre-io/vobject/issues/635

martijnvankekem avatar Jan 17 '24 14:01 martijnvankekem

please add a test case

staabm avatar Jan 17 '24 15:01 staabm

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a5df355) 98.76% compared to head (3cf6669) 98.76%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #636   +/-   ##
=========================================
  Coverage     98.76%   98.76%           
- Complexity     1866     1867    +1     
=========================================
  Files            71       71           
  Lines          5325     5325           
=========================================
  Hits           5259     5259           
  Misses           66       66           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 17 '24 15:01 codecov[bot]

@martijnvankekem your PR comes directly from the master branch of your fork, which is a bit more diffcult to manage. I rebased in a branch in my fork and made and up-to-date PR #640 The CI all passes there - good, no existing test cases were broken.

Please let us know the details of an example iCal structure - what does it pass in $parameters["VALUE"] It will be good to add a unite test case that has a reasonably realistic example of this.

phil-davis avatar Feb 11 '24 08:02 phil-davis