Markus Staab

icon indicating a website link https://staabm.github.io/ icon indicating an email [email protected]

icon location Germany icon location I am available for paid support of PHPStan and related static analysis tooling.

Results 959 comments of Markus Staab

PHPStan is slower than usual

Having xdebug loaded while running phpstan is a nogo IMO (if you don't want to debug phpstan itself). In my experience just having xdebug loaded no matter activated or not,...

PHPStan is slower than usual

AFAIR was the carbon phpdoc perf problem fixed a while ago

PHPStan is slower than usual

does the result only influence when the progressbar gets rendered or does it also has a impact on the overall analysis time?

PHPStan is slower than usual

I wonder whether we should print out a warning for the php cli jit - in a similar way we do it for xdebug - as it seems it can...

sprintf with non-empty-string arguments

I am working on it and will provide a PR later today

preg_match bugs

I think its a bug in the Hoa AST, which we walk here: https://github.com/phpstan/phpstan-src/blob/d842380a1f07014d045dd42d6ccd4204a85e688a/src/Type/Php/RegexArrayShapeMatcher.php#L204-L235 @mvorisek could you have a look at the grammar etc?

preg_match bugs

thanks. I will have another deeper look then. support would still be welcome :) _edit: fixes in https://github.com/phpstan/phpstan-src/pull/3184_

Validate the `ignoreErrors` directive for accidental duplicates

In my experience breaking the baseline or introduce subtle mistakes by manual editing happens pretty often. Thats the reason why we usually generate the baseline from scratch using the phpstan...

`Call to function is_null() with Foo|null will always evaluate to false` in do-while loop condition

the problem is not related to the used loop. it also happens in regular if statements. it looks like the nested assignment triggers the false-positive: https://phpstan.org/r/2f35dfa2-efc6-42c5-a8bf-5a7328180c69 when we use a...

Allow throwing exceptions from __toString() not detected since level 4

you need to add phpdocs to make phpstan aware that a function/method is throwing (alternatively create a extension for that). just by looking at the sources, phpstan is not able...