Markus Staab
Markus Staab
> Also, FunctionCallParametersCheck::check() accepts a single scope and $funcCall where it gets its arguments. This might be easier to fix. We need a new virtual node for each of Node\Expr\FuncCall|Node\Expr\MethodCall|Node\Expr\StaticCall|Node\Expr\New_...
@canvural the referenced issue is also talking about `continue`, which likely needs another test and/or fix
I agree with @maks-rafalko that I don't see the value yet, which this mutation provides (independent from the implemtation in this PR). Detection of a unused variable seems like a...
I think this will work when https://github.com/JetBrains/phpstorm-stubs/pull/1681 landed
tested locally with the latest phpstorm stubs ``` ➜ phpstan-src git:(2.0.x) ✗ php -v PHP 8.4.0-dev (cli) (built: May 24 2024 22:35:21) (NTS) Copyright (c) The PHP Group Zend Engine...
> if you'd like to find more suitable colors let me know hey @xepozz I am neither a designer nor a infection corporate design guru. the SVG logo was produced...
Misses a type-inference test which fails without the patch using `assertType`
> Do we already have type inference over variables? it seems it also does not work for count nope, we don't in such cases.
fywiw: assignments in nested-expressions or conditions are problematic for a lot more tools - not just infection...and also for humans because it leads to less readable code. so at best...
Can you share a reproducer of the perf problem, so I can profile it locally?