Markus Staab
Markus Staab
I was just crawling thru github for this particular php compat problem. Its not important for me to make this repo PHP 8.4 compatible
> I think this would be better filled by using [`ReflectionFunction::isAnonymous`](https://www.php.net/manual/en/reflectionfunction.isanonymous.php) in 8.2 and up thats right, but it would require raising the [min-php version requirement](https://github.com/pmmp/PocketMine-MP/blob/08c6e63aac45a450fe3b437616ee8aa2500e04e2/composer.json#L8)
resolved conflicts
I will finalize this PR when back at my windows laptop next week
good point. ``` 2) PHPStan\Rules\Comparison\ImpossibleCheckTypeFunctionCallRuleTest::testBug6788 Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -' +'13: Call to function chdir() with non-empty-string will always evaluate to...
the last commit is fixing cases like ```php
I am usually looking at GitHub annotations, therefore I like having them all rendered. stoping after 10 sounds like a good idea. :+1: for `--stop-on-escapes=X`
@sebastianbergmann I was able to reproduce the issue and can also see how it depends on https://github.com/sebastianbergmann/phpunit/commit/4e52bb6#diff-42df2a075f4f6210e6960e016357a9eddc7007ac25766f34ca0679c3e4d70d55R194 I could look into, whether we can stop fiddling with xdebug mode, when...
Hmm... Actually I think it would be best if the test also would declare its requirement on a certain xdebug.mode ini value. Having a test depend on a global php.ini...
> PS: I only just realized that `RequiresSetting` might be for ini settings, I searched [docs.phpunit.de/en/10.5/attributes.html](https://docs.phpunit.de/en/10.5/attributes.html) for "ini" in the past but did not find any results. yeah, I have...