Markus Staab

Results 1464 comments of Markus Staab

> I could look into, whether we can stop fiddling with xdebug mode, when a process-isolated test declares `#[RequiresPhpExtension('xdebug')]`. > how does that sound? implemented in https://github.com/sebastianbergmann/phpunit/pull/6353

currently one test is failling: ``` 1) /Users/staabm/workspace/phpunit/tests/end-to-end/regression/5592-process-isolation.phpt Failed asserting that string matches format description. --- Expected +++ Actual @@ @@ -- -There was 1 risky test: +There were 2...

alternatively we add the notion of units like ``` timeoutForSmallTests="1s" timeoutForMediumTests="10s" timeoutForLargeTests="60s" ``` or ``` timeoutForSmallTests="1000ms" timeoutForMediumTests="10000ms" timeoutForLargeTests="60000ms" ``` etc.

indeed. maybe raising a feature request for php-src is one way to go then

> 1. **PHP-Parser Support**: Infection uses `nikic/php-parser: ^5.3` which already supports the `weakReferences` option for `ParentConnectingVisitor`. The option was added in php-parser v5.5.0. correct, I implemented it ;) > I...

I agree that as long as all our *Mutator, *Visitor, *Traverser etc. classes only use local variables (stay stateless), and are not created via `Container->get()` methods, we should not have...

your PR has impact on more open bugs. please look at the changes and decide whether these are correct/intended https://github.com/phpstan/phpstan-src/actions/runs/13947226248?pr=3888 please add additional tests to cover this bugs, in case...

Agree that adding a new option is a pain. 👍 having a POC of the mentioned pattern would help to get everyone on the same page, whether it will improve...