phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard

Resolve template with value of BackEnum

Open VincentLanglet opened this issue 1 month ago • 8 comments

Closes https://github.com/phpstan/phpstan/issues/12219 Closes https://github.com/phpstan/phpstan/issues/13638 Closes https://github.com/phpstan/phpstan/issues/13282 Closes https://github.com/phpstan/phpstan/issues/13782

VincentLanglet avatar Nov 11 '25 14:11 VincentLanglet

This pull request has been marked as ready for review.

phpstan-bot avatar Nov 11 '25 14:11 phpstan-bot

interessting.. does it also solve https://github.com/phpstan/phpstan/issues/13782 ?

staabm avatar Nov 11 '25 14:11 staabm

interessting.. does it also solve phpstan/phpstan#13782 ?

You don't appear on the issue bot https://github.com/phpstan/phpstan-src/actions/runs/19269104831?pr=4548 But I can take a look after this one is merged

VincentLanglet avatar Nov 11 '25 15:11 VincentLanglet

You don't appear on the issue bot

yes, thats because the issue does not yet have a label like "bug" or "feature request". issue-bot does not look into unlabelled issues

staabm avatar Nov 11 '25 15:11 staabm

You don't appear on the issue bot

yes, thats because the issue does not yet have a label like "bug" or "feature request". issue-bot does not look into unlabelled issues

Oh ok. Test added and seems like it does close https://github.com/phpstan/phpstan/issues/13782.

VincentLanglet avatar Nov 11 '25 15:11 VincentLanglet

Hi @staabm, when I run

vendor/bin/phpunit tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php --filter=testBug12219

both mutator are caught locally.

Any idea why it could be reported on CI ? Is there some cache ?

VincentLanglet avatar Dec 05 '25 12:12 VincentLanglet

Hi @staabm, when I run

vendor/bin/phpunit tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php --filter=testBug12219

both mutator are caught locally.

Any idea why it could be reported on CI ? Is there some cache ?

As shown by https://github.com/phpstan/phpstan-src/pull/4548/commits/6cb52a2049cf9499edc8e25942d5250e1ea6823b

if I tried the mutant reported by https://github.com/phpstan/phpstan-src/actions/runs/19963970402/job/57251263461?pr=4548

it failed.

I got the same issue with the following PR https://github.com/phpstan/phpstan-src/pull/4548

Either I misunderstand something, either it's buggy

VincentLanglet avatar Dec 05 '25 15:12 VincentLanglet

I had a look but cannot yet make sense of it

staabm avatar Dec 05 '25 16:12 staabm