Markus Staab

icon indicating a website link https://staabm.github.io/ icon indicating an email [email protected]

icon location Germany icon location I am available for paid support of PHPStan and related static analysis tooling.

Results 1464 comments of Markus Staab

Unknown service "Infection\Configuration\ConfigurationFactory"

> The alternative is that you still include phpstan itself in the build-infection. on phpstan-src side, I already fixed it by upgrading the relevant lib in https://github.com/phpstan/phpstan-src/pull/4617

Unknown service "Infection\Configuration\ConfigurationFactory"

I wonder why infection needs the application-under-test autoloader at all...? To find custom mutators?

DX: allow ignoring of mutations inline code (`@infection-ignore MutatorName`)

ohh nice, I didn't realize we have something similar already. my request was about ignoring a single mutator, so something like `@infection-ignore ` e.g. [in my recent PR](https://github.com/infection/infection/pull/2289/files) I would...

PHPStan does not report any issue when using conditionally defined symbols

@ondrejmirtes to properly solve this we maybe should turn `ReflectionProvider->hasFunction` from `bool` to `TrinaryLogic` in 2.x?

Paypal JS SDK not loading for some users

we also see this issue

[epic] AST based pre-filters

> do a first pass of the AST before generating any mutation. I plan to open dedicated epic/RFC for it, but I have a question that can already be debated...

Introduce allowFloatBoolNullAsArrayKey parameter

I would go with one of the allowFloatBoolNullAsArrayKey variants, as otherwise we need to document somewhere what "loose" or "strict" means in this context

CI: add `failOnDeprecation="true"` to PHPUnit config

I am travelling atm. Can have a look in a few days

CI: add `failOnDeprecation="true"` to PHPUnit config

> There are deprecations thrown in `RuleSetTest::provideAllRulesFromSetsCases`, which in PHPUnit 12 [fails](https://github.com/sebastianbergmann/phpunit/pull/6293) the tests. > > Adding `PHPUnit\Framework\Attributes\IgnoreDeprecations` to those tests somehow started to fail other ones. could you be...

POC: Stream TestRunner output instead of custom progress bar

I think streaming the TestRunners output instead of building our tool agnostic on top has the following benefits - people get the output of their test tool of choice, which...