Shane Smiskol

Results 1136 comments of Shane Smiskol

:eyes: ```python batman@workstation-shane:~/openpilot/selfdrive/debug$ ./check_can_parser_performance.py 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 10/10 [00:01

> After this PR, we can simplify car/interface by using only one CanParser. With a single call to update_string for parsing all messages, there's no need to repeatedly feed identical...

On a comma 3X: ``` 6000 CAN packets, 10 runs 300.33 mean ms, 302.04 max ms, 296.67 min ms, 1.42 std ms 0.0501 mean ms / CAN packet vs. 6000...

Production connect doesn't send setRouteViewed if you visit a route from URL directly (or ctrl+click to open in new tab) since the device and profile aren't fetched yet on component...

fixed once connect gets deployed

Yes, the safety isn't merged: https://github.com/commaai/panda/pull/1123

Another case `a2bddce0b6747e10/000003eb--0f891e5a10/9`: ![image](https://github.com/user-attachments/assets/9b9c6ed3-0406-481f-a689-2c81bacc8a77)

Another case https://connect.comma.ai/57048cfce01d9625/0000034a--9f0d6fc36b/103/130 ![image](https://github.com/user-attachments/assets/85d3a884-4621-4121-a62a-889a8e41e853)

Another example on Toyota: https://connect.comma.ai/6ac3968bd1f66985/0000003b--e11775e688/430/482 ![image](https://github.com/user-attachments/assets/b4e6e833-d9d5-4f03-b2e5-594fa7d572b1)

Another slow start from this: https://connect.comma.ai/d9b97c1d3b8c39b2/0000002b--a0ecfaf597/4271/4292