openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

VW PQ: add fingerprint for new car model

Open dkiiv opened this issue 1 year ago • 3 comments

FingerPrint

Car Volkswagen Jetta Sportwagen TDI, 2013 (2011-2014)

  • behind dashcam until hurdles for VW PQ are resolved

Route 578742b26807f756/00000010--41ee3e5bec

Car Model Port:

Checklist

  • [X ] added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
    • omitted from PR, car is behind dashcam mode and therefor not included in generated doc
  • [X ] test route added to routes.py
  • [X ] route with openpilot: 578742b26807f756/00000010--41ee3e5bec
  • [N/A ] route with stock system: n/a
  • [X ] car harness used (if comma doesn't sell it, put N/A): VW J533 harness

dkiiv avatar Jun 26 '24 20:06 dkiiv

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar Jun 26 '24 20:06 github-actions[bot]

the route: 578742b26807f756/00000010--41ee3e5bec

fails on the check/tests because it isnt in the CI bucket yet. i have it preserved + public in useradmin for the time being.

dkiiv avatar Jun 26 '24 20:06 dkiiv

@jyoung8607 can you review? I pushed the route

sshane avatar Jun 27 '24 00:06 sshane

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

sshane avatar Aug 20 '24 06:08 sshane