opendbc
opendbc copied to clipboard
Tesla Model 3/Y bugs + improvements
- [x] There are faults we don't handle with FSD long and openpilot lateral. We can 1) detect when FSD is turned on and warn user to switch to TACC, or 2) automatically send a message to switch to TACC (Hyundai CAN FD does something similar with the ADAS ECU) - https://github.com/commaai/opendbc/pull/1978, https://github.com/commaai/opendbc/pull/2055
- [ ] Temporary steering fault when overriding lateral very forcefully. Does the fault signal go high with FSD? If so, ignore in this case, else figure out how to not fault the steering.
- It does not fault in TACC, need to do the above! EDIT: I only tested with OP long
- [ ] similar to above, if you override hard it temp faults then resumes steering. I think the autopilot ECU disables steering before this happens
- [ ] When releasing after overriding above the set speed the car brakes aggressively - change to enabled to fix jerk https://github.com/commaai/opendbc/blob/634196f190f6b560f307436ad53cba42ace20068/opendbc/car/tesla/teslacan.py#L30
- [x] better ignition signal - https://github.com/commaai/panda/pull/2153
- [x] implement cancel - https://github.com/commaai/opendbc/pull/1734
- [x] handle max lateral accel faulting EPAS https://github.com/commaai/opendbc/issues/1760
- [ ] test max lateral jerk
- [ ] test stock AEB works
- [x] faults above 360 degrees - https://github.com/commaai/opendbc/pull/1793
- [ ] steering pressed is now too sensitive, activates lane changes on accident if going over bumps. adjust right in the middle with a higher threshold or longer time
- [x] with auto blinker cancel turned off, a light press only shows up for a split second on the UI for a lane change - https://github.com/commaai/opendbc/pull/2057
- [ ] detect traffic control (for lights and signs) and enforce disable since it sounds a warning
- [x] FSD still does the blinkers (and who knows what else)
- [x] can we improve the lane change nudge? - https://github.com/commaai/opendbc/pull/1730
- [ ] try out the "torque blending" fork
- [ ] Passthrough ASS / Autopark / Lane Keeping
Summon goes into the autopark/summon state before ACC enables, but Autopark enables ACC right away so we currently can't know to forward it. Maybe we need to allow some delay on our cancel command for a few frames so we have some time to read the autopark state.