slipher
slipher
Rebased, and also fixed the Chinese options which were missing from one menu.
If we're going to return std::string we should just return it by value and get rid of the static buffers.
> Isn't that a bunch of extra copies and allocations? This commit by its nature adds a bunch of extra copies and allocations. Writing in a static char buffer avoids...
> Unlike for [std::vector::clear](https://en.cppreference.com/w/cpp/container/vector/clear), the C++ standard does not explicitly require that [capacity](https://en.cppreference.com/w/cpp/string/basic_string/capacity) is unchanged by this function, but existing implementations do not change capacity. This means that they do...
I think we could get rid of the "async" stuff except logs if we just write the files on the main thread. Will take a closer look when I get...
I see 2 nontrivial shortcomings: - sgame background navgen is not cancelable. If you change map while it is running, the server will freeze until all threads finish generating their...
Apparently increasing the limit on tiles *decreases* the limit on some other thing? From NavmeshGenerator::WriteFile() ``` // there are 22 bits to store a tile and its polys int tileBits...
Seems wasteful to generate two identical navcons. Couldn't we make only the navcons need two versions? Or add a flag to the navcons that it requires the advanced granger?
> But consistent and easy to maintain in the future. We are already generating identical navmeshes for dretch and mantis. If someone tries to change either's size, they will not...
> Maybe we should simply move this into the C++ source, as many bot settings are not done in config files anyway. What about that? Fine with me. Do you...