PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

removing rnd reuse logic (disabled by default)

Open emmacware opened this issue 8 months ago • 4 comments

emmacware avatar Jun 04 '25 09:06 emmacware

OK, in the 2D kinematic setup, the reuse logic is enabled by default: https://github.com/open-atmos/PySDM/blob/20c83400c8954148579efb1659cf8a0e3a96f758/examples/PySDM_examples/Morrison_and_Grabowski_2007/common.py#L32

slayoo avatar Jun 14 '25 23:06 slayoo

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 85.46%. Comparing base (20c8340) to head (94ce24c). :warning: Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
- Coverage   85.53%   85.46%   -0.08%     
==========================================
  Files         396      394       -2     
  Lines        9601     9541      -60     
==========================================
- Hits         8212     8154      -58     
+ Misses       1389     1387       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 14 '25 23:06 codecov[bot]

IIUC, with the reuse disabled, we are shuffling all n_sd numbers regardless of how many are actually needed in a given substep. So, I'd suggest that before removing the reuse logic, we implement a scheme to alter the amount of shuffled numbers depending on how many are actually needed in a given substep

slayoo avatar Jun 15 '25 00:06 slayoo

Stale pull request message

github-actions[bot] avatar Sep 13 '25 13:09 github-actions[bot]