Steve Howell
Steve Howell
I don't really like the name `actions.py`. If we're gonna split stuff out here, I think we want modules that do more specific clumps of functions, so e.g. `links.py` could...
I think I'd rename `arguments.py` to `globals.py`.
@AasthaGupta Thanks for working on this! The code looks pretty clean, and we'll probably have you just squash the test changes into your first commit. @timabbott Before we merge, I...
Also, I'll summarize the approach that Aastha took here, for Tim's benefit: * in narrow.activate, set opts.exclude_muted_topics when you know you're doing a stream narrow (there's already a code branch...
@AasthaGupta The next step here is probably to discuss this on #backend if you have questions about what @timabbott is suggesting. Basically, I think the path forward is this: *...
@vaidap Can you follow up on this? Has the testimonials PR been merged yet?
This looks great to me! @graszka22 Can you do a quick sweep for minor things like unnecessary imports? @timabbott The overall structure of this change seems really solid to me....
I did a line-by-line review of the JS code, and it looks great! I had a few comments there. From an architectural standpoint, I think I found an interesting problem...
Hi @graszka22 I'm just following up on this to see if you're still working on it. I think this PR is really good work, so I hope you can do...
Can you give a more descriptive title to the PR and clean up the commit messages? Thanks!