Steve Howell
Steve Howell
I didn't read this super closely, but it seems like we are introducing a lot of server code for muting, when we already have decent support for muting in the...
@timabbott I'm not sure what the best way to open the settings menu is, but it seems like setting window.location.hash mimics what happens when you go through the gear menu,...
I merged two of these commands, so you'll need to rebase.
Thanks for rebasing. I edited the PR title to reflect that it's just /mute_topic now.
It feel like this introduces a lot of CSS for the size of the feature. Is there a way to build off of existing styles more?
Oh, gotcha. It's actually in the PR description--it may be worth adding at least a brief summary of that to the commit message(s)?
@timabbott @mahimg This PR looks pretty solid to me, although I think we might want consider an approach where we call clearTimeout when messages are successfully delivered. It would be...
My concern is that the timeout logic will still kick in after the server-failing stuff has correctly happened.
To elaborate on my concern for server failures, we need to make sure there's not any strange interactions between `echo.send_message_error` and any logic that happens with the timer. This is...
Looking better! I think you should strive to split out the test into three different tests (or three different functions, to be specific), and then have helper functions as needed...