[WIP] frontend: Fix links being clear from link text for landing page.

[vaidap]

Ran the Chrome accessibility tools on hello/. It came up with:

• The purpose of each link should be clear from the link text : fixed it with this commit
• Text elements should have a reasonable contrast ratio For most of the page text-- I suppose we don't want to be modifying this?
• Meaningful images should not be used in element backgrounds for the company logos and the octopus at the bottom. We could either give the div an aria-label with the name of the company, or port the images to be not background-images, and then adding an alt.

@brockwhittaker do you maybe have thoughts on this?

[smarx]

Automated message from Dropbox CLA bot

@vaidap, it looks like you've already signed the Dropbox CLA. Thanks!

[brockwhittaker]

I don't really see any images that are meaningful to an accessible experience that are displayed as background images. I only see the laptop and the octopus at the bottom of the screen. Both aren't really necessary.

[timabbott]

@vaidap for the apps section, I think the capitalization should be fixed for the ARIA labels ("Windows" and other product names should be capitalized how the products' names are). And we probably just want to add those strings to the exclude list for the translation linter for aria-label, since I think we don't need to translate these product names.

[vaidap]

• capitalised products
• also added aria-label attributes to the company images-- when hovering with a screen reader this reads out the company names, rather than completely ignoring them.
• I am getting a Please remove exclusions for file templates/zerver/hello.html: set(['aria-label="Web app"']) error with 'exclude_line': [('templates/zerver/hello.html', 'aria-label="Web app"')]},, so i just set the linter to completely ignore hello.html for aria-label -- i'm not sure what i'm doing wrong in how i'm writing the exclusion?

[vaidap]

this PR is waiting for the testimonials part to be extracted into a separate html file, so the linter can be set to ignore that specific html file.

[showell]

@vaidap Can you follow up on this? Has the testimonials PR been merged yet?

[vaidap]

pinged Brock about it!

[zulipbot]

Heads up @vaidap, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

[zulipbot]

Heads up @vaidap, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

[timabbott]

Closing this; we're rewriting the /hello page from scratch; hopefully the rewrite will improve accessibility naturally, but in any case, that'd need to be new work. Thanks @vaidap!