Steve Howell
Steve Howell
Overall approach seems reasonable.
I merged the first and third commits for now.
@adnrs96 @HarshitOnGitHub It might make sense to abandon this PR for now, and we can re-open it after 1.7 gets released, and at that time we can be a little...
I think the ideal thing here is to check against a fixed set of data that is semi-realistic. I know that doesn't protect us against the class of bugs of...
@AasthaGupta The conflict here is due to a change I merged from you (HUBOT_INTEGRATIONS_LEGACY), so hopefully that will be an easy thing for you to fix. Let's make the order...
I'm not convinced that either search algorithm is the bottleneck here. I think this may be a rendering thing. String searches are generally super fast.
@rishig I'm un-assigning myself here, as I think we want Tim to handle this, since it has performance implications and I haven't really been tracking it.
The Travis failures here are indicating you need to mock `FormData` with `set_global`.
I wasn't clear about my advice on extracting functions. I was thinking that you could have a two-step process: * filter stream drafts (really simple function to extract) * further...
Yep, thanks!