Steve Howell

Results 108 comments of Steve Howell

https://github.com/zulip/zulip/pull/16529 is a superset of this. I'm leaving this open only to make it easier for me to find until Rohitt's PR is ready to get merged. My PR is...

I support the first two here. I am meh on theme. The last commit is intriguing.

The first three seem fine to me, and it might make sense to just push them in their own PR to get a clean build. For the validation piece, it's...

@neiljp Just a quick reminder that you can probably create a new PR with the first three commits here to get a clean build, and we can at least get...

It's probably worth rebasing this PR, since I made some changes to the presence system recently that might be important here. Fortunately, there are apparently no file conflicts to resolve,...

@timabbott Hold off on merging this, as I am gonna cherry-pick the "get last_active date" commit on to my list_render branch and then modify it a bit. Then the second...

@sahil839 We just merged https://github.com/zulip/zulip/commit/0d2d7d31e228b48252501ff9f41c6ffd24374e9a You will want to rebase off the latest master and remove the corresponding commit from your branch. Thanks for working on this!

It looks like this commit changes a lot of stuff that you didn't intend to change. Did you have some kind of issue with rebasing or accidentally saving old files?