Steve Howell
Steve Howell
One thing we should do before pushing this out is to make sure we have a test that prevents some malicious user trying to send a message like `!!!
@timabbott This LGTM. It's a pretty concise way of doing it using selectors and a little extra markup. The other alternative would be for the handler to check `people.is_my_user_id` or...
Actually, one thing--I believe these can all be squashed into a single commit.
FYI here's some feedback from Rishi: https://chat.zulip.org/#narrow/stream/101-design/topic/user.20status.20design/near/694978 Tim, it's probably worth giving this a quick look, anyway, just to get a feel for it.
This looks pretty reasonable--thanks for updating the tests!
@Jagansivam28 Thanks for working on this! This is a great example of full-stack development on Zulip, and you seem to have found all the major moving parts. I think one...
@sahil839 Can you give an update on the status of this PR? I know this issue sort of sent us down the rabbit hole of making sure that we weren't...
I'm working on a deeper fix here. I'll probably close this PR once I get to a pretty solid point on my branch. Thanks for working on this @sahil839 --...
I haven't quite fixed this yet, but you can see that my recent commits are leading up to a fix here: https://github.com/zulip/zulip/commits?author=showell
In particular the below commit is sort of a preview of how I will split up handling of Users and Deactivated Users, which should help fix this issue: https://github.com/zulip/zulip/commit/5c16bb9c990daad26d9d14b9e406c33aaeeed078 There's...