Stefan Feilmeier
Stefan Feilmeier
@lukasrgr Sometimes I just still like to write some code myself :-). I agree, the other tasks (chartjs + replacement for datepicker) should be done in separate PRs. Just started...
Referencing this helpful comment by @Byonnem https://community.openems.io/t/recommended-angular-version-date-19-06-2023/1677
@lukasrgr or @venu-sagar: Could you please have a look?
@venu-sagar: I receive an error `src/app/app.module.ts(60,45): error TS2531: Object is possibly 'null'.` in line `{ provide: LOCALE_ID, useFactory: () => (Language.getByKey(localStorage.LANGUAGE) ?? Language.getByBrowserLang(navigator.language)).key },`
Thanks @Sn0w3y. We already have a `Language.DEFAULT`, so I think it makes sense to use that. I'll fix it this way: ```typescript { provide: LOCALE_ID, useFactory: () => (Language.getByKey(localStorage.LANGUAGE) ??...
@michaelgrill: Could you have a look please? This is also discussed in the Community: https://community.openems.io/t/unintended-backend-overload-detection/6614
@miettal: We try to move translations "closer to where they are used" to having multiple translation files was done by purpose.
@lukasrgr or @venu-sagar: Please review
We have too many open PRs with similar issues. I suggest we work on #2566 first (see the discussions on Coding Guidelines there). Afterwards we can re-open these PRs one...