openems icon indicating copy to clipboard operation
openems copied to clipboard

Sungrow String and ESS Implementation

Open Sn0w3y opened this issue 1 year ago • 2 comments

Based on the Implementation of @clehne in opernikus-common fork. I adapted it to use ElectricityMeter

Thanks to them

Sn0w3y avatar Feb 07 '24 12:02 Sn0w3y

We have too many open PRs with similar issues. I suggest we work on #2566 first (see the discussions on Coding Guidelines there). Afterwards we can re-open these PRs one at a time. Thanks!

sfeilmeier avatar Mar 11 '24 08:03 sfeilmeier

Code Coverage

github-actions[bot] avatar Apr 01 '24 21:04 github-actions[bot]

Any news on this? @tsicking would I be forced to merge the PR myself for my first experience with OpenEMS or is there any schedule planned to accept this PR?

Giermann avatar Aug 16 '24 09:08 Giermann

Closed as i guess it is a WIP

Sn0w3y avatar Aug 16 '24 10:08 Sn0w3y

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: There is a different number of reports uploaded between BASE (d00e0e9) and HEAD (b8316cb). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d00e0e9) HEAD (b8316cb)
2 1
Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #2528       +/-   ##
==============================================
- Coverage      55.89%   25.63%   -30.25%     
==============================================
  Files           2077      254     -1823     
  Lines          87948     6361    -81587     
  Branches        6494      953     -5541     
==============================================
- Hits           49149     1630    -47519     
+ Misses         37115     4657    -32458     
+ Partials        1684       74     -1610     

codecov[bot] avatar Aug 16 '24 10:08 codecov[bot]

Any news on this? @tsicking would I be forced to merge the PR myself for my first experience with OpenEMS or is there any schedule planned to accept this PR?

We are still working on it and we are testing it thoroughly. I will update this PR when we are done. You can merge it yourself and can use it as a starting point.

tsicking avatar Aug 16 '24 15:08 tsicking