Stefan Feilmeier

Results 112 comments of Stefan Feilmeier

@venu-sagar: Can you please review this? (This my note above on UPPER_CASE - either fix it yourself or wait for @Sn0w3y)

@Sn0w3y: You should really, really try to get comfortable with Github Forks, Branches, Pull-Requests,... it would make your live (and my/our lives) so much easier, when contributing and reviewing your...

> Will try my best @sfeilmeier Vielleicht können wir auch einmal eine kleine Schulung per Teams machen und einen Pull-Request beispielhaft mit Github Desktop erstellen. Im Moment sind es wirklich...

Thanks for the PR. I've been thinking about a similar functionality, but would prefer a different approach: - `enableRecharge = false` can already be achieved by setting `rechargePower` to a...

@da-Kai This layout will become obsolete with the new navigation (see prototype in EVSE)

@Sn0w3y It's still very much work-in-progress and no-UI/UX-designers-involved-yet, but these are two recent screenshots of the mobile App with a new multi-level, bottom navigation approach: ![grafik](https://github.com/user-attachments/assets/dcd0a921-5169-4b8f-9e83-0a415e4179ba)

@lukasrgr: Can you please take this over? Unfortunately the update has breaking changes, e.g. ```` ./src/app/shared/pickdate/pickdate.component.ts:3:0-89 - Error: Module not found: Error: Package path ./esm is not exported from package...

Thank you! It looks very good on first sight, but has the same flaws as the existing implementations - with possibly blocking the Core Cycle. I'd suggest waiting till #2381...

@clehne I updated some parts of the Code to latest OpenEMS SunSpec. Unfortunately our SunSpecCodeGenerator can still not generate code for "Modules" inside a block. Also I fixed/update a former...

@lukasrgr / @venu-sagar: Is this ready to be merged? It should anyway work independently of #2238 to stay backwards compatible, right? Please add me as reviewer if required - otherwise...