openems icon indicating copy to clipboard operation
openems copied to clipboard

UI: Update to Angular 16

Open sfeilmeier opened this issue 2 years ago • 6 comments

This PR targets the version update to Angular 16. Relevant documents:

  • https://update.angular.io/?v=15.0-16.0
  • https://angular.io/guide/update-to-version-16
  • https://ionicframework.com/docs/updating/7-0 (optional)

Current blockers are:

  • ngx-spinner - but that will change soon https://github.com/Napster2210/ngx-spinner/issues/258

  • ng2-charts - we are still on 2.9.4, which is incompatible with Angular Ivy https://www.chartjs.org/docs/latest/migration/v3-migration.html

    • PR: #2392
  • angular-mydatepicker - is also not compatible with Ivy and seems to be unmaintained: https://github.com/kekeh/angular-mydatepicker/issues/116

  • Refactoring of widgets before going to migrate:

Features:

  • https://github.com/OpenEMS/openems/pull/2287#issuecomment-1695747282

TODO

sfeilmeier avatar May 23 '23 07:05 sfeilmeier

@lukasrgr: FYI. Will use this PR to join efforts

sfeilmeier avatar May 23 '23 07:05 sfeilmeier

@sfeilmeier we could have saved some resources and time, if you had told me earlier, that you wanted it to do like this =)

lukasrgr avatar May 23 '23 13:05 lukasrgr

@sfeilmeier the best procedure would be updating chartjs and ng2 charts seperately from this PR, what do you think?

lukasrgr avatar May 23 '23 13:05 lukasrgr

@lukasrgr Sometimes I just still like to write some code myself :-). I agree, the other tasks (chartjs + replacement for datepicker) should be done in separate PRs. Just started this PR to track the general process.

sfeilmeier avatar May 23 '23 20:05 sfeilmeier

Before updating angular, first whole history has to be refactored, to make the transition easier.

Angular 16 currently does not support chartjs

lukasrgr avatar May 25 '23 07:05 lukasrgr

Referencing this helpful comment by @Byonnem

https://community.openems.io/t/recommended-angular-version-date-19-06-2023/1677

sfeilmeier avatar Jun 21 '23 13:06 sfeilmeier