openems icon indicating copy to clipboard operation
openems copied to clipboard

Improve querylimit handling to avoid unintended increment due to type conflicts

Open ikegam opened this issue 9 months ago • 3 comments

Previously, the backend incremented querylimit even for type conflicts in InfluxDB queries. Since querylimit should only reflect actual overload cases, this change modifies the handling logic to prevent increments caused solely by type conflicts.

I have tested this PR, and it appears to be working as expected. However, since this affects a core part of the backend functionality, I'm opening it initially as a Draft PR for further review and discussion.

ikegam avatar Mar 17 '25 06:03 ikegam

Codecov Report

:x: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

:x: Your patch status has failed because the patch coverage (16.67%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3052      +/-   ##
=============================================
- Coverage      58.56%   58.48%   -0.07%     
  Complexity       154      154              
=============================================
  Files           2488     2488              
  Lines         105828   105826       -2     
  Branches        7805     7806       +1     
=============================================
- Hits           61964    61879      -85     
- Misses         41602    41694      +92     
+ Partials        2262     2253       -9     
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 17 '25 06:03 codecov[bot]

@michaelgrill: Could you have a look please?

This is also discussed in the Community: https://community.openems.io/t/unintended-backend-overload-detection/6614

sfeilmeier avatar Mar 19 '25 14:03 sfeilmeier

We have operated our backend several months and it works well as expected with this patch. so I have updated the PR to ready.

ikegam avatar May 20 '25 01:05 ikegam

This PR has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Sep 17 '25 02:09 github-actions[bot]

Closing this PR due to inactivity.

github-actions[bot] avatar Oct 01 '25 02:10 github-actions[bot]