Stefan Feilmeier

Results 112 comments of Stefan Feilmeier

@pooran-c Could you please do a review here? You have a lot of experience implementing meters.

@lukasrgr Could you take over, please?

@da-Kai: FYI. I know you have been working on this as well. According to https://adoptium.net/de/supported-platforms/ Temurin is unfortunately currently not supporting "Linux (ARM 32-bit Hard-Float)" (armhf). We should validate this...

@michaelgrill: Can you please take over? ~~Should we switch this caching to a library that handles updating internally? Guava provides a nice Cache feature: https://github.com/google/guava/wiki/cachesexplained~~ Reconsiderung: no, this does not...

> I will add a Configurable Time to the Worker aswell as "Enable and Disable" Option :) One value is sufficient. Negative or zero means "disable".

I had a quick look and renamed the config property to `cacheRefreshInterval`. But `InitializeEdgesWorker` also has to be renamed, because the name does not make any sense anymore. Also Checkstyle...

Can you configure weblate to output in the same format (i.e. with 2-space indentation) to reduce the number of touched files in the pull request?

Looks much better know. Unfortunately weblate still orders the entries differently (alphabetically), but we are likely not able to change that. Good work!

@michaelgrill: FYI. Maybe you could also review instead of Lukas.

Yes, everything in that direction is welcome! Ideally we would unify these State-Channels in a common Nature for all Shelly implementations. What about #3203. Should I merge it already or...