Stefan Feilmeier

Results 112 comments of Stefan Feilmeier

See breaking note in https://github.com/OpenEMS/openems/pull/2462#issuecomment-1862381632

@michaelgrill: Can you please add your opinion?

@Sn0w3y: Thank you for the effort. Please read and execute the contribution guidelines carefully, especially this: https://openems.github.io/openems.io/openems/latest/contribute/coding-guidelines.html#_openems_edge_backend. Also we cannot review and merge, before the Continuous Integration (CI) build is...

@Sn0w3y: In Eclipse you should always run Checkstyle and all JUnit tests (of your bundle). Afterwards run `./tools/prepare-commit.sh` as suggested in Coding Guidelines. The script runs well in a WSL...

Thanks for the effort. What do you think about the readme format I used for the KACO PV-Inverter (Compatibility, etc.): https://github.com/OpenEMS/openems/pull/2056/files#diff-7ea9b39e1464a0b628672b2587791b35c968acbd4c8e9ed4f4eb0d2010171c93 I think it adds value to the generated Antora...

@saeedniko: It seems @Sn0w3y has done the same work as you did :-( Can you please compare the PRs and review this one?

@saeedniko: Thanks for checking it! How well did you review everything? Unfortunately @Sn0w3y has mixed structural changes (UPPER_CASE) with content (actual translations). This makes it very hard for me to...

I am putting this to WIP for now. We have an internal PR by @saeedniko with the same target that is currently under in-depth review by some colleages. I'll backport...

@Sn0w3y: I hijacked your PR and backported some changes I have recently been applying for ENTSO-E for FEMS.

@Bishalghimire1997 & @pooran-c: Thank you for your amazing work. This is definitely the most complete implementation of LSTM in Java out there. 🚀 I did some final touches here and...