Özkan Sezer
Özkan Sezer
OK, I pulled this in. Thanks.
Related: gcc-4.4 and gcc-4.5 emit the following warnings: ``` audio/mpeglayer3.cpp: In member function ‘void MPEGaudio::layer3dequantizesample(int, int, int (*)[18], REAL (*)[18])’: audio/mpeglayer3.cpp:957: warning: array subscript is above array bounds audio/mpeglayer3.cpp:957: warning:...
testsem has been occasionally segfaulting in my fork's CI runs lately. This one is the second time I've run into it: https://github.com/sezero/SDL/actions/runs/9215737866/job/25354666540 EDIT: Forgot to mention that it is happening...
Just hit this in my fork in SDL2 branch: https://github.com/sezero/SDL/actions/runs/9910933216/job/27382477447
And this is in release-2.30.x branch here in this repo: https://github.com/libsdl-org/SDL/actions/runs/9910876675/job/27382301210
Does sdl3 need any similer attention?
> Yeah, @madebr, go ahead and push the above patch and close this one. What is preventing the patch from being applied to SDL2/3 ?
What is it that sdl2-config actually wants to do but /bin/sh of solaris fails to comply? (I am _guessing_ that it's `$(...)` syntax??) Should we not fix that instead of...
Yes, we should revert that. I think https://github.com/libsdl-org/SDL/commit/799d39a3022415f698cb92f44b872c8513d83249 (from PR/#5751) is responsible for the issue in this ticket.
> which are the new features introduced in [799d39a](https://github.com/libsdl-org/SDL/commit/799d39a3022415f698cb92f44b872c8513d83249). And why did we need that patch, what did it really gain us?