Özkan Sezer

Results 569 comments of Özkan Sezer

Is this purely personal experience or is the hardware in use really have a play?

> @sezero I'm not sure I understand the question You hear clicks/pops, @icculus can not, and I could not either (but I'm not audiophile.) Some hear, some don't: That was...

Can you please rebase to current master squash into a single commit? @slouken, @icculus: yours to review.

Is this eligible for 2.0.22 (reviewed?) or should wait for later?

Should this go in to 2.0.18, after review of course?

@slouken, @icculus: This was marked as `target-2.0.16` in original bugzilla: Needs you guys' love & care.

> Moving to SDL 3.0, to review our alpha blending handling. > > @sezero, feel free to look at this sooner It's not my thing at all, it's @bavison's: I...

https://github.com/libsdl-org/SDL/runs/5441478306?check_suite_focus=true#step:6:190 ``` /home/runner/work/SDL/SDL/src/video/x11/SDL_x11xinput2.c:170:22: warning: declaration of ‘i’ shadows a previous local [-Wshadow] 170 | int ndevices,i,j,k,dev_i=0; | ^ /home/runner/work/SDL/SDL/src/video/x11/SDL_x11xinput2.c:138:21: note: shadowed declaration is here 138 | int event, err, i;...

Possibly needs autotools and cmake checks for `XIScrollClassInfo`

> Possibly needs autotools and cmake checks for `XIScrollClassInfo` Or, since `SDL_VIDEO_DRIVER_X11_XINPUT2_SUPPORTS_MULTITOUCH` already requires 2.1+, the new code probably can be guarded with that existing macro. Maintainers to decide.