Özkan Sezer

For old gcc, I propose the following: disables funtionality for gcc < 3.1, tested with gcc2.95. Don't know what to do with old MSVC. ```diff diff --git a/include/SDL3/SDL_dlopennote.h b/include/SDL3/SDL_dlopennote.h index...

Pushed the above patch with minor revisions as https://github.com/libsdl-org/SDL/commit/04aa74b5f93a965c34e94728d2d3a64757899061 Ancient MSVC issues still not resolved.

> > +/* Variadic macros are not supported */ > > +#define SDL_ELF_NOTE_DLOPEN(args...) > > + > > Doesn't this syntax mean variadic macros _are_ supported? It does, so I...

> If we don't find a way, I would remove the following lines from `SDL_dlopennote.h`: > > [SDL/include/SDL3/SDL_dlopennote.h](https://github.com/libsdl-org/SDL/blob/281ac6c3bb619f614616a82891c3e39d3f05ceea/include/SDL3/SDL_dlopennote.h#L218-L219) > > Lines 218 to 219 in [281ac6c](/libsdl-org/SDL/commit/281ac6c3bb619f614616a82891c3e39d3f05ceea) > /* Variadic macros...

> I'll remove the line(s), can you first check whether you can get [this suggestion](https://github.com/libsdl-org/SDL/issues/14214#issuecomment-3393716129) working? If if's viable, then we can avoid a build breaking change. Can you attach...

Patch ran through `iconv -f UTF-16 -t UTF-8`: [patch.txt](https://github.com/user-attachments/files/22875150/patch.txt) Reproduced your experience: `-E` outputs are the same but patched version emits that preprocessor error and refuses to build. I don't...

> (I don't like this suggestion) Heh, me either. Requiring working variadic macros functionality in SDL3 isn't a bad thing though: _And_ it is for elf targets where we have...

One thing that can be done is, not including SDL_dlopennote.h in SDL.h by default and manually include it where it is actually used. That would prevent most accidents.

I'd say just keep the macro name as is.

Whitespace and style changes are making it difficult to read the actual changes. Tiny patch to make it build on alder systems: ```diff diff --git a/src/core/linux/SDL_dbus.h b/src/core/linux/SDL_dbus.h index 738fc06..27dcd41 100644...