Özkan Sezer

Results 570 comments of Özkan Sezer

OK, all arguments are said, I guess. Wrap it up and close as @icculus says? (even though I don't actually like it..)

> We're missing lots of information what exactly is not working. > > Does solaris not understand `$()` process substitution and do we need to use old-style `` ` ``...

> > Does it not understand the --? > > ``` > bash-4.3# /bin/sh > # dirname -- > . > ``` > > That...appears to be okay? The real...

How did this happen: https://github.com/libsdl-org/sdl2-compat/actions/runs/10331541340/job/28601815563 CC: @madebr

OK, pushed https://github.com/libsdl-org/SDL/commit/f93920a4f16c4d16f6cd3797191e7894542dac4b to work around it. @icculus: revise it as you see fit.

The following good for sdl2-compat? (Other SDL3 changes may need additional compat-side changes which I didn't look.) ```diff diff --git a/src/sdl2_compat.c b/src/sdl2_compat.c index 277b846..77d13eb 100644 --- a/src/sdl2_compat.c +++ b/src/sdl2_compat.c @@...

> Yep, that looks good. OK, applied and pushed.

Also reported to minimp3 mainstream as https://github.com/lieff/minimp3/issues/119

Why don't you just use an incremented index, e.g.: ```diff diff --git a/src/get_ip.c b/src/get_ip.c index dd039c1..196f751 100644 --- a/src/get_ip.c +++ b/src/get_ip.c @@ -238,7 +238,7 @@ ret_copy: void W32_CALL freehostent (struct...

> So does it mean djgpp 2.03 doesn't have a prototype for it? djgpp < 2.04 simply doesn't have [v]snprintf(), and naturally doesn't have prototypes of them. That's simply what...