Özkan Sezer

PING?

PING?

Look at my fork at https://github.com/sezero/libmodplug/tree/sezero which fixes those and more

For -Wregister : https://github.com/sezero/libmodplug/commit/c0db4e2c053f5ccd962c5a3ff7033adafe58d520 For misc others, check these out: https://github.com/sezero/libmodplug/commit/3a7fac8842d3f8745fd050bd6371e4ebe7c918bc https://github.com/sezero/libmodplug/commit/2d762bcd2ec6d643672895be48dcd6a9ebfa6e0e https://github.com/sezero/libmodplug/commit/fc591cb0bd985d6cf7bfe2a33115224b4c6f35b7 https://github.com/sezero/libmodplug/commit/b11d0dda2e1e4060537be2c765ba0394bb7cc181 https://github.com/sezero/libmodplug/commit/40638b6a77d5da28013b87048565c9c1566abed9 (There may be more, but these are the ones easy to find.)

Created https://github.com/Konstanty/libmodplug/pull/70

Now that PR/70 is in, which warnings do remain? Or, can this be closed?

Thanks for this, I merged this in my fork (https://github.com/sezero/libmodplug.git) The project seems dead for a while now, I wonder we will see any updates..

@sagamusix: So it should be a two lines addition as in the following, yes? ``` diff --git a/src/snd_fx.cpp b/src/snd_fx.cpp index c7f8549..d424936 100644 --- a/src/snd_fx.cpp +++ b/src/snd_fx.cpp @@ -2118,11 +2118,16 @@...

@sagamusix: OK, I applied this to my fork for now: https://github.com/sezero/libmodplug/commit/92d855e33798d509bf29b9874a68c44ef0cd64f2 I'm not much in my capable-of-thinking mode at the moment, so if you have further fixes please post :)

> the patch proposed by sezero also causes artifacts on some other loops. Having a patch for that would be welcome.