Özkan Sezer
Özkan Sezer
The attached patch removes exported symbol lists from cmake and msvc project file, and marks exported syms explicitly with `__declspec(dllexport)` (Hopefully I didn't screw up the msvc project file..) EDIT:...
> > Also, I believe that the `in_wv.lng` gets included in the dll because the .lng file is never referenced in the NSI installation script. > > That in_wv.lng thing...
Would it not be OK to simply Sys_Error with any such bad maps in Mod_LoadEdges ?? ~[bad patch deleted]~ Also: Can you give links to such bad maps please?
OK, should I close this then? Or, do you have a better patch?
.. and the correct check should be something like this I guess ? ```diff diff --git a/Quake/gl_model.c b/Quake/gl_model.c index 6e5cfd7..52bad53 100644 --- a/Quake/gl_model.c +++ b/Quake/gl_model.c @@ -1281,6 +1281,9 @@ static...
OK, I just tried several (surely not all) mods with the following: ```diff diff --git a/Quake/gl_model.c b/Quake/gl_model.c index 6e5cfd7..70b1689 100644 --- a/Quake/gl_model.c +++ b/Quake/gl_model.c @@ -1282,6 +1282,8 @@ static void...
... well, of course I couldn't hit the issue because I mistakenly compared with `
> IMO the right thing is do a developer warning on first encountering this, but silence after that, and just ignore the faces. Isn't the patch above doing that already...
I.e.: drop the warning at render time altogether?
> > I.e.: drop the warning at render time altogether? > > That's what I think it meant yes, but @ericwa would have to confirm that. OK, here is what...