Sean McArthur

Results 1306 comments of Sean McArthur

So I originally assumed that lints/warnings would be entirely in the console (nothing in the subscriber). The reasons were: - I didn't want to do too much computing in-process of...

Now I'm starting to lean back the other way, that the warnings code should be entirely in the `console`, and not in the subscriber. That'd reduce the amount of work...

- The proc macro hit seems unfortunate. - Say more about switching back to enums. Do most just get an `Inner` variant again? That sucked for trying to match on...

> how close is hyper to something like a 1.0? This year. It's a team goal. > I think the point here is that if hyper 1.0 occurs before tower-service...

Sorry, I was slightly wrong. The issue is that if the `MakeService::Future` polls into an error (fails to connect), `Reconnect` will return that error in its `poll_ready`, but still be...

Instead of blocking 0.1, we should just remove the `tower-reconnect` re-export from `tower`.

This morning after thinking about it some more, I started to lean more in this direction: - **Reconnect**: In the proxy, we can treat the error from `Reconnect::poll_ready` as terminal,...

Yes, that would help if there is a general timeout applied to all requests, since it's unlikely that a request at the front of the queue is not timed out,...

@briansmith you mentioned at RustConf that we might be able to merge this? WDYT?

The change in https://github.com/summerwind/h2spec/commit/672e145691882dd649d79fc51922fff083d74a86 requires a GOAWAY frame, where as the spec mentions: > A GOAWAY frame (Section 6.8) MAY be omitted in this case, since an invalid preface indicates...