Sean McArthur

Results 1306 comments of Sean McArthur

I assume you mean that at `tokio::spawn`, if the user uses essentially `tokio::spawn(future.instrument(span))`, that span's user-set values would be worth including, which I agree. How would we detect that? I...

We do have much of the "data" already, since the console is essentially just interpreting a series of events from `tracing` about task polls and wakes with timestamps. The "hard"...

After some further investigation, I see why this is now in place. The "buffered data" amount is stored as a `WindowSize`, which represents the type from the HTTP2 spec, that...

Maybe an `Event::StreamError`?

By making this change, is it catching a bug and triggering a panic?

It seems in `fn open()`, we check that the number of currently active received streams is under the max, and if at the limit, then the stream is rejected (likely...

Shouldn't it be sufficient to just set the `max_reset_streams` to something? Anything over that limit should be forgotten immediately, no?

Hm, ya... The first thing that comes to my mind is to store some `h2::Something` type in the `Request::extensions()` indicating a `:protocol` pseudo header. Does that work cleanly? Should it?

There isn't (yet) a public API to see that, no. We could design one!

We could store the `longest_poll` on the task `Stats` that get sent normally, and then start with a default (but configurable) high maximum limit, such as a 1 second. Even...