Sean McArthur
Sean McArthur
Actually, `HeaderValue` in the `http` crate already has `set_sensitive`, could that be used? Would it make sense to also add the flag to `http::uri::PathAndQuery`?
Yea, we could add `set_not_indexed` or whatever if really necessary, but either way, `set_sensitive` would work in this case, since Apple is just recommending how to keep churn in the...
A bigger effort would be to replace the single massive lock to per-stream locks. There might still need to be a large lock, but the goal would be to not...
This is excellent work, thanks for getting started here! I think one thing to work out that may affect this PR is whether we want a histogram per task, or...
Yes, I believe we've discussed before that there are cases that this should send `NO_ERROR` instead of `CANCEL`. Probably only in this specific case: The full response has been sent...
Ummmm, hard for me to remember. I imagine if you changed that function without the conditional, some unit test would complain? That might show which unit test needs to be...
Nice, looks good to me!
Thanks again for the excellent work! If you're ever interested in helping on other aspects of `h2`, we'd welcome your work gladly!
Hey, thanks for the PR! Hm, I'd love to understand this better. I _think_ the current behavior is correct, that if the server sends a `CANCEL` reset, we should return...
I see, I think I understand the issue now. The problem isn't so much about `CANCEL` specifically, it's that if a stream is reset, even though some data was received...