Sean McArthur

Results 1306 comments of Sean McArthur

Is there something specifically different there that isn't done here?

For headers that can have multiple values, and thus are using `FlatCsv`, should handle that stuff. It might miss an edge case... We could add tests!

Oh OK, I think *I* was confused. The title said "all headers", and I assumed not really *all*, but many, since there some headers that specifically forbid multiple values. You're...

The tag is meant to say the issue needs more comments about how and if to move forward. The discussion can happen on the issue.

Yea, like @jxs mentioned, the builder in `h2` basically is the "settings" type, and we could do similar here.

We _change_ it separately from Tokio. My preference (without stating this is a requirement) is that we only increase the required version when it would give a significant improvement to...

Thanks for the PR! I've purposefully been very careful about what exactly is exposed in the public API, since I learned my lesson before when this crate was part of...

Wow, I'm so sorry, @pietroalbini, that I missed the new changes in #67. It looks pretty much exactly what I've described, when I quickly scroll through. I need to sit...

I hadn't seen that structured header values RFC, looks cool! Regarding the Reporting-Endpoints, I'd suggest first figuring it out in Servo, and afterwards we can see about adding it here...

The title says *to* `StatusCode`, so it this `StatusCode::try_from(usize)`, etc? I'm -0. I think asking people to realize that a status code is a `u16` is useful, and people can...