Sean McArthur comments

Results 1307 comments of


                                            Sean McArthur

feat: Implement accept_invalid_hostnames for rustls

Thanks for adding this! Yes, I'd prefer the clippy changes weren't part of the PR. (I don't generally listen to clippy, actually...)

URI: how to distinguish from invalid port vs no port number

It probably should return an error when the Uri/Authority itself is parsed, not when calling the accessor.

feat: enable non-'static where possible

That's what I kind of thought when looking at this too, it's a breaking change. We could consider it for the next major release, but I don't know when that...

Hope to support "Max Conntions Per Host”.

Note, we haven't yet replaced the pool in reqwest, that will come soon.

feat(conn): support HTTP proxy basic authentication

Thanks for the PR! We currently are able to send proxy auth without this. For instance, reqwest adds the information based on various factors. So, part of me thinks it...

feat(conn): Generic over executor and update docs

Oh, thanks! Let me just rebase my own branch on master to clear up the unrelated parts.

Convert Future<Body> into Body

Seems reasonable to me :)