Sean McArthur

Results 1307 comments of Sean McArthur

I guess it depends on how the additional checks affect performance. Is it possible to see some benchmark results of before and after?

The `sha-1` crate is published by the "RustCrypto" team, which I find valuable.

> many downstream crates to also not build This sounds like a different issue, there's no reason headers v0.3.7 should suddenly stop working. Wrapping up here, though, we've changed to...

This was discussed a bit in #73. In short, we don't want to tie the stability of `http` with that of `url`, and conversion between the two is possible without...

The type is intended for both server and client side HTTP. So, for instance, it can represent a CONNECT request, with only the host, or it can represent an OPTIONS...

What's wrong with the buffer type being generic on the connection? The generic propagation works similar to h2, the Body type must return the same type of buffer for the...

I have thought that perhaps classes of headers could be optional features. Like auth, conditionals, and the like...

It'd be best to plan what the features would be first, so that way the code part takes less back and forth. Does my comment about features as groups of...

Relevant discussion about why this hasn't been implemented in the past: https://github.com/hyperium/http/issues/73

Any missing constructors is due to not having spent the time to design one. Ideally the typed headers don't expose their internals, and a constructor validates that the type is...