Add a method to collect the DNS names from a certificate (finish work from #91 )

[Geal]

trafficstars

it's time we get this done :)

In this PR:

• rebase on current master
• change the untrusted dependency to the alpha crate like ring does
• fix various warnings (linters that prevented compilation)
• add WildcardDNSName, WildcardDNSNameRef, and the GeneralDNSNameRef enum
• remove the old test certificate with the c*.netflix.com name, to a certificate with *.netflix.com, since the name validation function is a bit more strict

cc @seanmonstar

[Geal]

the travis build failed with error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256' to '/Users/travis/.rustup/tmp/dvf9zas_bt4ybmn2_file' @briansmith could you restart the failed build job?

[Geal]

(rebased on master)

[Geal]

rebased again, all tests pass. @briansmith any ideas if this could be merged?

[seanmonstar]

@briansmith you mentioned at RustConf that we might be able to merge this? WDYT?

[Keruspe]

@briansmith any news on this?

[Geal]

ping @briansmith ?

[Geal]

@briansmith is there anything blocking this?

[Ten0]

@briansmith up

[Geal]

@briansmith is there anything blocking this PR from being merged? I could rebase it over #125 if needed. If it should not ever go into webpki (it's been 3 years already...), a clear "no" would be fine too

[briansmith]

Note: I renamed the "master" branch to "main". Sorry for the inconvenience. This PR has had its base branch updated to "main" but you'll need to deal with the change in your local repo yourself.

[Geal]

@briansmith it's rebased over main, let me know if you need any changes

[codecov[bot]]

Codecov Report

Merging #103 (f04436e) into main (9cf9f45) will increase coverage by 2.89%. The diff coverage is 83.83%.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   73.56%   76.45%   +2.89%     
==========================================
  Files          14       14              
  Lines        1362     1525     +163     
==========================================
+ Hits         1002     1166     +164     
+ Misses        360      359       -1     

Impacted Files	Coverage Δ
src/name/dns_name.rs	60.37% <43.47%> (-1.02%)	:arrow_down:
tests/integration.rs	99.24% <98.91%> (-0.76%)	:arrow_down:
src/name/verify.rs	27.22% <100.00%> (+23.08%)	:arrow_up:
src/webpki.rs	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9cf9f45...f04436e. Read the comment docs.

[Geal]

@briansmith all CI checks pass, it should be good to go now

[Chaostheorie]

Any chance of this getting merged?

[Ten0]

Since this repository is not maintained anymore, the main one seems to now be the fork at https://github.com/rustls/webpki.

In case you want to follow (or upvote it 🙄), this PR has been ported over to: https://github.com/rustls/webpki/pull/6

(as far as I'm concerned I'm still blocked on it since 2020)