Ruud Kamphuis

Results 363 comments of Ruud Kamphuis

Thanks for this PR. Could you please add some tests? And please rebase with `main`.

> The adapters cannot have a negative number of results, so the range conveys the actual requirement better than a simple integer typehint can without adding new runtime checks (which...

This is exactly what I'm looking for. Would be great to have this merged. 🙏

Getting the same issue while tracking a lot of events and then calling `segment.Close()`. ``` segment 2021/10/18 14:28:02 ERROR: sending request - Post "https://api.segment.io/v1/batch": context deadline exceeded (Client.Timeout exceeded while...

I was a bit surprised to find out there is no way to flush the client without closing it. :pray: Please add support for it so that I don't get...

Any news on this?

For anyone trying to work around this broken action, I decided to use the `gh` cli instead: ```yaml - name: Add comment on PR run: | cat

@mlocati Can you please approve the workflow so that we can see if the tests pass?

@mlocati Any idea what this could be?