Ruud Kamphuis

Results 363 comments of Ruud Kamphuis

Please also add Omega2 🙏

Maybe instead of this, it could be written as `Assert::true(isset($a->id));` ?

@zerkms You're right. However, in my use case, using Doctrine entities with autoincrement ids, this was fine as I just want to make sure there is a value. ```php class...

@zerkms `private int $id` cannot ever be null. PHPStan: `Call to static method Webmozart\Assert\Assert::notNull() with int will always evaluate to true.`

I think this is now handled in https://github.com/TomAnthony/itermocil/pull/122, right?

I think this is now handled in https://github.com/TomAnthony/itermocil/pull/122, right?

@z7zmey where is the https://github.com/z7zmey/php-parser/blob/master/internal/php7/php7.y file coming from? Did you make this yourself or is this provided by PHP?

@i582 Great that you are doing this!! 💪 Would it be an idea to move your fork to a GitHub organization so that it can live forever, is not bound...

@i582 Great! 🎉 I'll subscribe to https://github.com/VKCOM/php-parser/pull/1 then.

Could you please add some tests cases that show this fix is needed.