Ruud Kamphuis comments

Results 363 comments of


                                            Ruud Kamphuis

Installing extension from source doesn't work

I think the problem is that it reads the version from the package.xml: https://github.com/php-memcached-dev/php-memcached/blob/master/package.xml#L32 That version is not updated in `main` so therefore Pickle says it installs `3.1.5` while in...

Use pest to simplify test maintenance

Please don't do this and keep using PHPUnit, the tool that everyone uses. Having a test suite that everyone can work with makes it easier for newcomers to participate in...

Introduce `TypeReference` that allows linking types together without having to pass a reference to the actual type object or use callbacks

> How about `TypeReference` over [DeferredType](url)? I like it! > That would require including a type loader with the schema, not every schema has one. I guess we could throw...

Introduce `TypeReference` that allows linking types together without having to pass a reference to the actual type object or use callbacks

Updated the PR to reflect `TypeReference`.

Introduce `TypeReference` that allows linking types together without having to pass a reference to the actual type object or use callbacks

Nice, but why not then just use the string format that is already in the GraphQL schema / spec? `[SomeType]!`

Introduce `TypeReference` that allows linking types together without having to pass a reference to the actual type object or use callbacks

That's true, but why should it be fully possible to work on its own? Isn't that design decision (made long time) one of the reasons why we now have all...

Introduce `TypeReference` that allows linking types together without having to pass a reference to the actual type object or use callbacks

> One problem could be that types can be part of multiple schemas. Definitely, and I'm currently in the process of introducing another schema next to our large 250 type...

Introduce `TypeReference` that allows linking types together without having to pass a reference to the actual type object or use callbacks

> Again, the main issue I see is making all the current APIs work with it. Basically all methods on types, fields and argument objects that return a Type will...

Support class bann rules

Please try https://github.com/spaze/phpstan-disallowed-calls/tree/v1.3.0 as it supports this now.

OTP releases not found

For anybody else getting this error: ``` remote: -----> Checking Erlang and Elixir versions remote: Will use the following versions: remote: * Stack cedar-14 remote: * Erlang 24.0 remote: *...