FOSOAuthServerBundle icon indicating copy to clipboard operation
FOSOAuthServerBundle copied to clipboard

Repository is now instanciated on the fly

Open abienvenu opened this issue 9 years ago • 5 comments

No more repository instantiated in constructor of ClientManager and TokenManager.

This avoids a database connection to be established for every request.

Fixes issue https://github.com/FriendsOfSymfony/FOSOAuthServerBundle/issues/422

abienvenu avatar Nov 18 '16 16:11 abienvenu

Tests are failing tho

ruudk avatar Jan 05 '17 19:01 ruudk

Right, there was a test conflicting with the very purpose of this pull request. I removed this test. There are still some failing tests, but I guess these out of memory errors are unrelated.

abienvenu avatar Jan 06 '17 08:01 abienvenu

The unit tests have improved greatly the last couple of weeks.

Could you rebase on top of master?

dinamic avatar Jan 31 '18 10:01 dinamic

Ok @dinamic , I made the rebase and tests are fine now.

abienvenu avatar Feb 01 '18 19:02 abienvenu

Can you handle authcodemanagers too?

dkarlovi avatar Feb 01 '18 19:02 dkarlovi

Yes @dkarlovi, good point. AuthCodeManagers are handled as well now.

abienvenu avatar Feb 02 '18 19:02 abienvenu