Ruud Kamphuis comments

Results 363 comments of


                                            Ruud Kamphuis

Check runs gets added to the wrong check suite

I have the same problem. @rmacklin The problem is, that if you have multiple workflows like this: the reported checks by reviewdog are put on the first (?) workflow instead...

Infinite loop when using trait in base and parent class

Same issue here. Started failing when I upgraded from 1.2.0 to 1.2.2 and with using `MockeryPHPUnitIntegration`. I'm using PHPUnit v7.5.8

Infinite loop when using trait in base and parent class

I found out why this is happening. I have a `MockeryTestCase` base class that imports the `MockeryPHPUnitIntegration` trait. In the test that extends from this class, I also imported `MockeryPHPUnitIntegration`....

Decryption failed when different aws-profile names used

Having the same issue. ``` # Does work AWS_PROFILE=production sops -i production/secrets.yaml # Does not work sops --aws-profile=production -i production/secrets.yaml ```

Enable confirmation for producers (#660)

Can you please give this PR a proper title?

route validation

Permalink: https://github.com/zalando/skipper/blob/0cc8c24b726a3f2da11594c86b125dead0c324c3/routing/datasource.go#L220-L222

kubernetes: ingress class appears to be ignored in route printing

I have the same problem. I'm using a public and private one and both skipper pods return the same routes.

kubernetes: ingress class appears to be ignored in route printing

@szuecs ``` name: private-skipper-ingress image: registry.opensource.zalan.do/pathfinder/skipper:v0.10.273 ports: - name: ingress-port containerPort: 9997 hostPort: 9997 - name: metrics-port containerPort: 9909 args: - "skipper" - "-kubernetes" - "-kubernetes-in-cluster" - "-address=:9997" - "-application-log-level=INFO"...

kubernetes: ingress class appears to be ignored in route printing

@szuecs Yes

assert_email_delivered_with not working with multiple emails

I'm having the same issue. I need to put the `assert_email_delivered_with` calls in the same order as the emails are being send. That is annoying, because for my integration test...