Ruud Kamphuis comments

Results 363 comments of


                                            Ruud Kamphuis

[DependencyInjection] Fix `PriorityTaggedServiceTrait` for `AsTaggedItem`

I checked it out but don't really understand what this fixes and how it's needed. But I just wanted you to add tests because that is something the Symfony reviewers...

Display stack trace on `--debug` without wrapping it in `[ ERROR ]` block style

I feel this happens because I run it with PHPStorm Run Configuration. I suspect it sets `COLUMNS` to a low number and therefore causes the wrapping.

DisallowedClass now introduces 2 errors instead of 1 that has count: 2

I think `disallowedImports` is not needed. I wouldn't use it. I don't care for imports of forbidden stuff. I only care about usage of forbidden things.

Introduce `disallowIn` as inverse of `allowIn`

I'm sorry but I can't remember why I wanted to use this back in 2021... But thanks for fixing it. Maybe I'll use it in the future 😊

Support the new methods in 1.4

Maybe good to change the title to `Support the new methods between 1.4 and 1.7` https://github.com/webmozart/assert/blob/1.7.0/CHANGELOG.md#170-2020-02-14

param fetcher convert integer query parameters to strings

Having the same issue when upgrading from 1.7 to latest.

param fetcher convert integer query parameters to strings

No sorry, something else changed. When you have allow blank without nullable the value becomes an empty string, that changed between 1.7 and up. Sorry for confusion.

[DoctrineParamConverter] The identifier id is missing for a query

I'm having the same issue, setting it to false did the trick.

Error while piping to circleci tests split --split-by=filesize Error splitting files: stat

Same happens for me when using `circleci tests glob "tests/Functional/**Test.php" | circleci tests split --split-by=timings`.

Added Symfony5 compatibility

Any news on this?