pickle icon indicating copy to clipboard operation
pickle copied to clipboard

Published 20 hours ago • verified publisher icon FriendsOfPHP

Fix default stability

Open b1rdex opened this issue 2 years ago • 5 comments

Fixes https://github.com/FriendsOfPHP/pickle/issues/247

Previous behavior: default to latest version, if no stability or version was requested. New behavior: default to stable.

b1rdex avatar Jul 22 '22 11:07 b1rdex

PR has bugs, I'm trying to fix it.

b1rdex avatar Jul 22 '22 12:07 b1rdex

Okay, I fixed the code. Ready for review.

Because the code was always broken, I had to update the test web server too – after the fix requests default to stable version when no stability/version is requested, but the broken behavior was to default to latest in such case.

b1rdex avatar Jul 22 '22 13:07 b1rdex

@mlocati Can you please approve the workflow so that we can see if the tests pass?

ruudk avatar Aug 17 '22 08:08 ruudk

Hi @mlocati @ruudk ! I see that tests pass – https://github.com/FriendsOfPHP/pickle/actions/runs/2718808503

Can you please review?

b1rdex avatar Oct 09 '22 07:10 b1rdex

Ping... We're seeing breaks again: https://github.com/yiisoft/yii2-docker/actions/runs/3654098169/jobs/6174221320

schmunk42 avatar Dec 13 '22 13:12 schmunk42