Rupert Swarbrick

Hi there! Something slightly odd has happened here: I think the `prim_assert.sv` file should include `prim_assert_standard_macros.svh` with Vivado (not the "dummy" file). Can you send a follow-up with the version...

@scottj97: Passing the const object is essentially what we're doing already. The `bool frozen` field is just checking that we didn't mess up in `spike.cc` and forget to call the...

Force-push rebases over the stuff that's been merged so far (not trivial: the design changed rather dramatically!). I've already split the first commit in the queue out (#955). I'll spin...

I've gone through this reasonably carefully. I'm not completely sure whether we can follow the light-weight signoff here, but hopefully this information will be useful either way. ## Commits since...

We had a V1 review meeting this afternoon. Notes [here](https://docs.google.com/document/d/1jlLVgrSooHNEPmzXNrAi7mjZ67Gt0lJD3X63bsqsA60/edit). The meeting was happy that we have satisfied the items on the V1 checklist, except for the fact that we...

Great, thanks guys.

It's probably much easier to re-open this PR and force-push to the branch that it uses. There are actually merge conflicts in #21619 as well, so this should be easier....

The DV smoke test is failing because the code doesn't compile. I think you're using a new `request_halt` task without actually declaring it :-) The simple solution is probably to...

Hmm, something has gone a little bit awry on the git side. I've just pulled the head of this PR and rebased onto `master` and will push the result. We'll...

Something has got a little bit shuffled around. I think what we want is probably two commits: 1. Define `request_halt` and use it in places that might need it. This...