Rupert Swarbrick

Results 187 comments of Rupert Swarbrick

Hi there! It sounds like things aren't properly installed. In particular, `riscv/devices.h` should appear in the `include` directory of a Spike installation. I'd suggest looking through your installation and working...

I'm not entirely sure what's wrong here, but the error message is your Python environment complaining that it doesn't know how do call a `classmethod` object as a function. I...

That's a bit odd: `RegressionMetadata` is the name of a class, so the solution that you have found is to call the class as a function(!). I don't think we'd...

I've just force-pushed to the PR to resolve some rebasing conflicts. No other change.

Thanks for this: the code looks really good. I've just re-read the testplan item, which ends with "Verify that the device does not send any handshake packet in response." I...

Hi @alees24! I'm working through old usbdev PRs and this was the oldest(!). I've just rebased it to the current head of master. Is this still something you're working on?

Cool, that makes sense. I'm going to rebase to fix the merge conflict, but I won't hit "merge" until that's sorted out.

Hi @vogelpi! Have you had a chance to talk to the PD team?

@vogelpi: Repeating the question, can we drop this primitive once we take the branch on master? Or is there any evidence that it is needed somewhere in the closed source?

Were we keeping it open until we'd upgraded the warnings to errors?