Robert Nagy comments

Results 722 comments of


                                            Robert Nagy

Feature: Rewrite ProxyAgent

We could implement `ProxyAgent` using these connector?

deps: update V8 to 13.0

It's in the v8 code. Maybe not enabled still?

deps: update V8 to 13.0

So basically Fast API is "broken"? This will cause some massive perf regressions (maybe good idea to kick of a benchmark CI to confirm). Can we involve someone with V8...

buffer: throw on invalid encoding in Buffer.from

@nodejs/buffer

Ability to externalize WASM was broken

@Uzlopak

refactor!: drop interceptors

I don't think it's a lot of work to just re do it from beginning?

net: defer self.destroy calls to nextTick

@mcollina FYI, this adds overhead to `net` to fix a bug in the "legacy" HTTP client. I don't mind per se, but it's not optimal since the bug is not...

net: defer self.destroy calls to nextTick

I don't think this is the right place to solve it. Not blocking since I don't have time to provide more meaningful feedback.

net: defer self.destroy calls to nextTick

Seems more like a bug in the http.request module and this is just a workaround/hack in `net` to solve something that is not part of `net`. Deferring calls to `destroy`...

net: defer self.destroy calls to nextTick

I still am of the opinion that there is nothing wrong with net and any change here should be done in the http client code.