Robert Nagy comments

Results 722 comments of


                                            Robert Nagy

buffer: validate UTF8 on fast path

@blexrob @jasnell @addaleax @anonrig @lemire C++ experts PTAL

buffer: validate UTF8 on fast path

@ShenHongFei Any chance I can get a full repro? It's interesting since both the slow and fast path should behave similarly now. If you don't want to share publicly you...

buffer: validate UTF8 on fast path

@ShenHongFei can you try again with your project. I think I might have found the issue.

buffer: validate UTF8 on fast path

For future reference: Simple fuzzing: ```js const assert = require('node:assert') const crypto = require('node:crypto') for (let i = 0; i < 1e6; i++) { const len = Math.floor(Math.random() * 128)...

buffer: validate UTF8 on fast path

https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1626/

dns round-robin interceptor + cache

@metcoder95

dns round-robin interceptor + cache

We did it like this: https://github.com/nxtedition/nxt-undici/blob/main/lib/interceptor/dns.js https://github.com/nxtedition/nxt-undici/blob/main/lib/interceptor/lookup.js Where our default lookup function is: ```js function defaultLookup(origin, opts, callback) { callback(null, Array.isArray(origin) ? origin[Math.floor(Math.random() * origin.length)] : origin) } ``` The...

Robert Nagy

buffer: validate UTF8 on fast path

buffer: validate UTF8 on fast path

buffer: validate UTF8 on fast path

buffer: validate UTF8 on fast path

buffer: validate UTF8 on fast path

dns round-robin interceptor + cache

dns round-robin interceptor + cache

perf: Optimize Header Validation

feat: preparsed Headers

bug: created readable for response without body