node icon indicating copy to clipboard operation
node copied to clipboard

buffer: throw on invalid encoding in Buffer.from

Open ronag opened this issue 1 year ago β€’ 5 comments

Refs: https://github.com/nodejs/node/pull/54533

ronag avatar Aug 27 '24 05:08 ronag

@nodejs/buffer

ronag avatar Aug 27 '24 05:08 ronag

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 87.32%. Comparing base (c00ea01) to head (9d335ca). :warning: Report is 3280 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54586      +/-   ##
==========================================
- Coverage   87.33%   87.32%   -0.01%     
==========================================
  Files         649      649              
  Lines      182620   182632      +12     
  Branches    35044    35033      -11     
==========================================
- Hits       159484   159481       -3     
- Misses      16397    16419      +22     
+ Partials     6739     6732       -7     
Files with missing lines Coverage Ξ”
lib/buffer.js 96.70% <100.00%> (ΓΈ)

... and 33 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 27 '24 07:08 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61534/

nodejs-github-bot avatar Aug 27 '24 08:08 nodejs-github-bot

PR is currently blocked from landing due to unreliable CI. Likely needs a rebase

jasnell avatar Sep 08 '24 03:09 jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/62166/

nodejs-github-bot avatar Sep 08 '24 09:09 nodejs-github-bot

What's the status here?

aduh95 avatar Nov 08 '25 14:11 aduh95

Can you push it again?

mcollina avatar Nov 08 '25 19:11 mcollina